linux-kernel - Re: [PATCH] JFS: use list_move instead of list_del/list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50579954.7030009@oracle.com>
Date:	Mon, 17 Sep 2012 16:42:44 -0500
From:	Dave Kleikamp <dave.kleikamp@...cle.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
CC:	yongjun_wei@...ndmicro.com.cn,
	jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] JFS: use list_move instead of list_del/list_add

Meant to reply earlier. I've sent this to linux-next and will target for
the next mainline merge window.

Thanks,
Shaggy

On 09/06/2012 02:33 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Using list_move() instead of list_del() + list_add().
> 
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  fs/jfs/jfs_txnmgr.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
> index bb8b661..5fcc02e 100644
> --- a/fs/jfs/jfs_txnmgr.c
> +++ b/fs/jfs/jfs_txnmgr.c
> @@ -2977,12 +2977,9 @@ int jfs_sync(void *arg)
>  				 * put back on the anon_list.
>  				 */
>  
> -				/* Take off anon_list */
> -				list_del(&jfs_ip->anon_inode_list);
> -
> -				/* Put on anon_list2 */
> -				list_add(&jfs_ip->anon_inode_list,
> -					 &TxAnchor.anon_list2);
> +				/* Move from anon_list to anon_list2 */
> +				list_move(&jfs_ip->anon_inode_list,
> +					  &TxAnchor.anon_list2);
>  
>  				TXN_UNLOCK();
>  				iput(ip);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/