linux-kernel - Re: [PATCH] drivers/target/target_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1347931430.10711.149.camel@haakon2.linux-iscsi.org>
Date:	Mon, 17 Sep 2012 18:23:50 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drivers/target/target_core_configfs.c: fix error
 return code

On Mon, 2012-09-17 at 20:05 +0200, Peter Senna Tschudin wrote:
> From: Peter Senna Tschudin <peter.senna@...il.com>
> 
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 

<SNIP>

> Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---

This bug-fix patch with a slightly more verbose commit log has been
applied to target-pending/for-next, along with a CC' to stable so it
get's picked up for v3.6.1 + friends.

Thanks Peter!

--nab

>  drivers/target/target_core_configfs.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index a1b4171..015f5be 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -3124,6 +3124,7 @@ static int __init target_core_init_configfs(void)
>  				GFP_KERNEL);
>  	if (!target_cg->default_groups) {
>  		pr_err("Unable to allocate target_cg->default_groups\n");
> +		ret = -ENOMEM;
>  		goto out_global;
>  	}
>  
> @@ -3139,6 +3140,7 @@ static int __init target_core_init_configfs(void)
>  				GFP_KERNEL);
>  	if (!hba_cg->default_groups) {
>  		pr_err("Unable to allocate hba_cg->default_groups\n");
> +		ret = -ENOMEM;
>  		goto out_global;
>  	}
>  	config_group_init_type_name(&alua_group,
> @@ -3154,6 +3156,7 @@ static int __init target_core_init_configfs(void)
>  			GFP_KERNEL);
>  	if (!alua_cg->default_groups) {
>  		pr_err("Unable to allocate alua_cg->default_groups\n");
> +		ret = -ENOMEM;
>  		goto out_global;
>  	}
>  
> @@ -3165,14 +3168,17 @@ static int __init target_core_init_configfs(void)
>  	 * Add core/alua/lu_gps/default_lu_gp
>  	 */
>  	lu_gp = core_alua_allocate_lu_gp("default_lu_gp", 1);
> -	if (IS_ERR(lu_gp))
> +	if (IS_ERR(lu_gp)) {
> +		ret = -ENOMEM;
>  		goto out_global;
> +	}
>  
>  	lu_gp_cg = &alua_lu_gps_group;
>  	lu_gp_cg->default_groups = kzalloc(sizeof(struct config_group) * 2,
>  			GFP_KERNEL);
>  	if (!lu_gp_cg->default_groups) {
>  		pr_err("Unable to allocate lu_gp_cg->default_groups\n");
> +		ret = -ENOMEM;
>  		goto out_global;
>  	}
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/