linux-kernel - Re: [PATCH v2 04/15] dmaengine: Pass no_wakeup parameter via device_prep_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1347958810.1943.176.camel@vkoul-udesk3>
Date:	Tue, 18 Sep 2012 14:30:10 +0530
From:	Vinod Koul <vinod.koul@...ux.intel.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>, Tony Lindgren <tony@...mide.com>,
	Dan Williams <djbw@...com>,
	Jarkko Nikula <jarkko.nikula@...mer.com>,
	alsa-devel@...a-project.org, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Janusz Krzysztofik <jkrzyszt@....icnet.pl>,
	Ricardo Neri <ricardo.neri@...com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Barry Song <baohua.song@....com>,
	Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>,
	Vista Silicon <javier.martin@...ta-silicon.com>,
	Zhangfei Gao <zhangfei.gao@...vell.com>,
	Shawn Guo <shawn.guo@...aro.org>,
	Laxman Dewangan <ldewangan@...dia.com>
Subject: Re: [PATCH v2 04/15] dmaengine: Pass no_wakeup parameter via
 device_prep_dma_cyclic() callback

On Tue, 2012-09-18 at 09:31 +0100, Russell King - ARM Linux wrote:
> On Mon, Sep 17, 2012 at 11:01:23AM +0200, Linus Walleij wrote:
> > On Thu, Sep 13, 2012 at 3:37 PM, Peter Ujfalusi <peter.ujfalusi@...com> wrote:
> > 
> > > Change the parameter list of device_prep_dma_cyclic() so the DMA drivers
> > > can receive the no_wakeup request coming from client drivers.
> > > This feature can be used during audio operation to disable all audio
> > > related interrupts.
> > >
> > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> > > CC: Nicolas Ferre <nicolas.ferre@...el.com>
> > > CC: Barry Song <baohua.song@....com>
> > > CC: Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>
> > > CC: Russell King - ARM Linux <linux@....linux.org.uk>
> > > CC: Vista Silicon <javier.martin@...ta-silicon.com>
> > > CC: Zhangfei Gao <zhangfei.gao@...vell.com>
> > > CC: Shawn Guo <shawn.guo@...aro.org>
> > > CC: Laxman Dewangan <ldewangan@...dia.com>
> > 
> > After some discussion with clever people I know I have come to the conclusion
> > that this is a good idea, so:
> > Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> NAKed-by: me
> 
> If you look at the other sub-threads of the patch you're acking, you'll
> notice that there's a v3 of this patch set which changes the way this is
> done.
Was it a genuine mistake, think v3 reply v2? Or less caffeine..... :)


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/