linux-kernel - [Re: [PATCH 2/2] drivers/s390/net/ctcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1347965539.29091.3.camel@br9gv9yg.de.ibm.com>
Date:	Tue, 18 Sep 2012 12:52:19 +0200
From:	Ursula Braun <ubraun@...ux.vnet.ibm.com>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	blaschka@...ux.vnet.ibm.com, mschwid2@...ux.vnet.ibm.com,
	heicars2@...ux.vnet.ibm.com, linux-s390@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [Re: [PATCH 2/2] drivers/s390/net/ctcm_main.c: fix error return
 code]


thanks, Peter, your patch will be added to our next patch series
submission.

Ursula Braun











________________________________________________________________________



From: Peter Senna Tschudin <peter.senna@...il.com>

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
   when != &ret
*if(...)
{
 ... when != ret = e2
     when forall
return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>
---
drivers/s390/net/ctcm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c
index 5227e57..98ea9cc 100644
--- a/drivers/s390/net/ctcm_main.c
+++ b/drivers/s390/net/ctcm_main.c
@@ -1454,7 +1454,7 @@ static int add_channel(struct ccw_device *cdev,
enum ctcm_channel_types type,

ch_fsm_len, GFP_KERNEL);
                 }
                 if (ch->fsm == NULL)
-
 goto free_return;
+
 goto nomem_return;

                 fsm_newstate(ch->fsm, CTC_STATE_IDLE);

-- 
1.7.11.4




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/