linux-kernel - Re: [PATCHv3 5/6] media: Convert struct i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Sep 2012 14:42:26 +0300
From:	Felipe Balbi <balbi@...com>
To:	Shubhrajyoti D <shubhrajyoti@...com>
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	julia.lawall@...6.fr
Subject: Re: [PATCHv3 5/6] media: Convert struct i2c_msg initialization to
 C99 format

On Tue, Sep 18, 2012 at 05:14:31PM +0530, Shubhrajyoti D wrote:
>         Convert the struct i2c_msg initialization to C99 format. This makes
>         maintaining and editing the code simpler. Also helps once other fields
>         like transferred are added in future.

no need for these tabs here.

FWIW:

Reviewed-by: Felipe Balbi <balbi@...com>

> 
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@...com>
> ---
>  drivers/media/radio/saa7706h.c |   15 +++++++++++++--
>  1 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/radio/saa7706h.c b/drivers/media/radio/saa7706h.c
> index bb953ef..54db36c 100644
> --- a/drivers/media/radio/saa7706h.c
> +++ b/drivers/media/radio/saa7706h.c
> @@ -199,8 +199,19 @@ static int saa7706h_get_reg16(struct v4l2_subdev *sd, u16 reg)
>  	u8 buf[2];
>  	int err;
>  	u8 regaddr[] = {reg >> 8, reg};
> -	struct i2c_msg msg[] = { {client->addr, 0, sizeof(regaddr), regaddr},
> -				{client->addr, I2C_M_RD, sizeof(buf), buf} };
> +	struct i2c_msg msg[] = {
> +					{
> +						.addr = client->addr,
> +						.len = sizeof(regaddr),
> +						.buf = regaddr
> +					},
> +					{
> +						.addr = client->addr,
> +						.flags = I2C_M_RD,
> +						.len = sizeof(buf),
> +						.buf = buf
> +					}
> +				};
>  
>  	err = saa7706h_i2c_transfer(client, msg, ARRAY_SIZE(msg));
>  	if (err)
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)