linux-kernel - RE: [PATCH] drivers/rapidio/devices/tsi721.c: fix error return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8D983423E7EDF846BB3056827B8CC5D12E7C4AFF@corpmail1.na.ads.idt.com>
Date:	Tue, 18 Sep 2012 12:27:55 +0000
From:	"Bounine, Alexandre" <Alexandre.Bounine@....com>
To:	Peter Senna Tschudin <peter.senna@...il.com>,
	"mporter@...nel.crashing.org" <mporter@...nel.crashing.org>
CC:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"chul.kim@....com" <chul.kim@....com>,
	"jiang.liu@...wei.com" <jiang.liu@...wei.com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] drivers/rapidio/devices/tsi721.c: fix error return code

On Monday, Sep.17, at 2012 4:14 AM Peter Senna Tschudin wrote:
> 
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
> 
... skip ...
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---
>  drivers/rapidio/devices/tsi721.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/rapidio/devices/tsi721.c
> b/drivers/rapidio/devices/tsi721.c
> index 1974359..78dff6f 100644
> --- a/drivers/rapidio/devices/tsi721.c
> +++ b/drivers/rapidio/devices/tsi721.c
> @@ -2316,7 +2316,8 @@ static int __devinit tsi721_probe(struct pci_dev
> *pdev,
> 
>  	/* Configure DMA attributes. */
>  	if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
> -		if (pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) {
> +		err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
> +		if (err) {
>  			dev_info(&pdev->dev, "Unable to set DMA mask\n");
>  			goto err_unmap_bars;
>  		}
> --
> 1.7.11.4

Acked-by: Alexandre Bounine <alexandre.bounine@....com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/