linux-kernel - [PATCH] gpio-pcf857x: avoid an empty kernel message in case no irq is configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120918165006.3852c06d@frequentis.com>
Date:	Tue, 18 Sep 2012 16:50:06 +0200
From:	Christian Engelmayer <christian.engelmayer@...quentis.com>
To:	<linux-kernel@...r.kernel.org>
CC:	<christian.engelmayer@...quentis.com>, <grant.likely@...retlab.ca>
Subject: [PATCH] gpio-pcf857x: avoid an empty kernel message in case no irq
 is configured

Avoid a needless kernel message in case there is no client irq to be ignored.

   [    2.856058] gpiochip_add: registered GPIOs 248 to 255 on device: pcf8574
   [    2.862830] pcf857x 1-0020:

Signed-off-by: Christian Engelmayer <christian.engelmayer@...quentis.com>
---
--- a/drivers/gpio/gpio-pcf857x.c	2012-07-06 09:19:07.000000000 +0200
+++ b/drivers/gpio/gpio-pcf857x.c	2012-07-06 09:21:15.000000000 +0200
@@ -290,8 +290,8 @@ static int pcf857x_probe(struct i2c_clie
 	 * methods can't be called from sleeping contexts.
 	 */
 
-	dev_info(&client->dev, "%s\n",
-			client->irq ? " (irq ignored)" : "");
+	if (client->irq)
+		dev_info(&client->dev, " (irq ignored)\n");
 
 	/* Let platform code set up the GPIOs and their users.
 	 * Now is the first time anyone could use them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/