linux-kernel - Re: USB: ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Sep 2012 17:37:32 +0100
From:	Greg KH <greg@...ah.com>
To:	Rene Buergel <rene.buergel@...ard.de>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: USB: ezusb: move ezusb.c from drivers/usb/serial to
 drivers/usb/misc

On Tue, Sep 18, 2012 at 09:03:01AM +0200, Rene Buergel wrote:
> This patch moves drivers/usb/serial/ezusb.c to drivers/usb/misc/and
> adapts Makefiles and Kconfigs
> 
> Signed-off-by: René Bürgel <rene.buergel@...ard.de>
> ---
> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
> index 1bfcd02..1c63b54 100644
> --- a/drivers/usb/misc/Kconfig
> +++ b/drivers/usb/misc/Kconfig
> @@ -244,3 +244,7 @@ config USB_YUREX
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called yurex.
>  
> +config USB_EZUSB
> +	bool "Functions for loading firmware on EZUSB chips"

This should be a tristate so the ezusb code can be a module on it's own.

Or I think it should, as it is, I get the following build errors with
this patch applied:

ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/whiteheat.ko] undefined!
ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan_pda.ko] undefined!
ERROR: "ezusb_fx1_set_reset" [drivers/usb/serial/keyspan_pda.ko] undefined!
ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan.ko] undefined!

Which is odd, as I thought those functions were exported.

So something is wrong here with this patch, I've applied the first 2, care to
redo this one so it works properly?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/