linux-kernel - Re: [PATCH -mm v2 2/2] coredump: add a new elf note with siginfo of the signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120918165744.GA25535@redhat.com>
Date:	Tue, 18 Sep 2012 18:57:45 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Roland McGrath <roland@...k.frob.com>
Cc:	Denys Vlasenko <vda.linux@...glemail.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Amerigo Wang <amwang@...hat.com>,
	"Jonathan M. Foote" <jmfoote@...t.org>,
	Pedro Alves <palves@...hat.com>
Subject: Re: [PATCH -mm v2 2/2] coredump: add a new elf note with siginfo
	of the signal

On 09/18, Roland McGrath wrote:
>
> > But, somehow I forgot about compat tasks when we discussed this before.
> > Perhaps the code above should do
> >
> > 	if (is_compat_task())
> > 		copy_siginfo_to_user32(...);
> > 	else
> > 		copy_siginfo_to_user(...);
> >
> > ?
>
> compat_binfmt_elf.c will define a separate copy of this code via #include.
> So it just needs #define copy_siginfo_to_user copy_siginfo_to_user32 or
> something like that, as the various other types and functions are handled.

Ah, yes, you are right. Much better.

But. It seems, it also needs to do s/siginfo_t/compat_siginfo/ somehow,
a simple '#define' obviously can't work.

IOW, elf_thread_core_info.signote should be either siginfo_t or
compat_siginfo, but the argument passed to ->core_dump() and callees
should be siginfo_t.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/