linux-kernel - Re: [PATCH] dmaengine: use kmem_cache_zalloc instead of kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1347938733.1943.169.camel@vkoul-udesk3>
Date:	Tue, 18 Sep 2012 08:55:33 +0530
From:	Vinod Koul <vinod.koul@...ux.intel.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	djbw@...com, yongjun_wei@...ndmicro.com.cn,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: use kmem_cache_zalloc instead of
 kmem_cache_alloc/memset

On Mon, 2012-08-27 at 12:40 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Using kmem_cache_zalloc() instead of kmem_cache_alloc() and memset().
> 
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/dma/ioat/dma_v2.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/ioat/dma_v2.c b/drivers/dma/ioat/dma_v2.c
> index 8689576..b9d6678 100644
> --- a/drivers/dma/ioat/dma_v2.c
> +++ b/drivers/dma/ioat/dma_v2.c
> @@ -434,12 +434,11 @@ static struct ioat_ring_ent *ioat2_alloc_ring_ent(struct dma_chan *chan, gfp_t f
>  		return NULL;
>  	memset(hw, 0, sizeof(*hw));
>  
> -	desc = kmem_cache_alloc(ioat2_cache, flags);
> +	desc = kmem_cache_zalloc(ioat2_cache, flags);
>  	if (!desc) {
>  		pci_pool_free(dma->dma_pool, hw, phys);
>  		return NULL;
>  	}
> -	memset(desc, 0, sizeof(*desc));
>  
>  	dma_async_tx_descriptor_init(&desc->txd, chan);
>  	desc->txd.tx_submit = ioat2_tx_submit_unlock;
Applied thanks


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/