linux-kernel - Re: [PATCH 3/3] i2c: OMAP fix driver initialization message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5058CA65.5080408@ti.com>
Date:	Tue, 18 Sep 2012 14:24:21 -0500
From:	a0919096 <b-cousson@...com>
To:	Pantelis Antoniou <panto@...oniou-consulting.com>
CC:	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Matt Porter <mporter@...com>,
	Koen Kooi <koen@...inion.thruhere.net>,
	Shubhrajyoti D <shubhrajyoti@...com>,
	Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH 3/3] i2c: OMAP fix driver initialization message

Hi Panto,

That patch is good, but a similar one was already posted by Florian.
https://patchwork.kernel.org/patch/1392671/

Checking the email thread it seems that Wolfram	pulled it.

Regards,
Benoit

On 9/19/2012 11:07 AM, Pantelis Antoniou wrote:
> The message spit out when the i2c-omap driver load is printing
> the platform device's id as a bus number. However when booting
> from OF id is -1, which is not so nice.
>
> Fix it by printing the adapter number.
>
> [    0.210467] omap_i2c 44e0b000.i2c: bus -1 rev2.4.0 at 400 kHz
> 	vs
> [    0.210467] omap_i2c 44e0b000.i2c: bus 0 rev2.4.0 at 400 kHz
>
> Signed-off-by: Pantelis Antoniou <panto@...oniou-consulting.com>
> ---
>   drivers/i2c/busses/i2c-omap.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index f722478..87bb705 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -1178,9 +1178,6 @@ omap_i2c_probe(struct platform_device *pdev)
>   		goto err_unuse_clocks;
>   	}
>
> -	dev_info(dev->dev, "bus %d rev%d.%d.%d at %d kHz\n", pdev->id,
> -		 dev->dtrev, dev->rev >> 4, dev->rev & 0xf, dev->speed);
> -
>   	adap = &dev->adapter;
>   	i2c_set_adapdata(adap, dev);
>   	adap->owner = THIS_MODULE;
> @@ -1204,6 +1201,9 @@ omap_i2c_probe(struct platform_device *pdev)
>   	if (IS_ERR(pinctrl))
>   		dev_warn(dev->dev, "pins are not configured from the driver\n");
>
> +	dev_info(dev->dev, "bus %d rev%d.%d.%d at %d kHz\n", adap->nr,
> +		 dev->dtrev, dev->rev >> 4, dev->rev & 0xf, dev->speed);
> +
>   	pm_runtime_mark_last_busy(dev->dev);
>   	pm_runtime_put_autosuspend(dev->dev);
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/