linux-kernel - Re: [RFC - PATCH] base:pm: prepare driver for common clock framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <201209182334.08229.rjw@sisk.pl>
Date:	Tue, 18 Sep 2012 23:34:08 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Murali Karicheri <m-karicheri2@...com>
Cc:	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	cyril@...com, mturquette@...aro.org,
	Magnus Damm <magnus.damm@...il.com>,
	"Linux-sh list" <linux-sh@...r.kernel.org>
Subject: Re: [RFC - PATCH] base:pm: prepare driver for common clock framework

On Saturday, September 15, 2012, Murali Karicheri wrote:
> As part of my work to migrate davinci SoC code to
> use common clk framework, I encountered an issue with this driver
> which is calling clk_enable() and clk_disable() without prepare()/
> unprepare(). This change is needed to enable common clock migration
> for davinci SoCs.
> 
> Signed-off-by: Murali Karicheri <m-karicheri2@...com>

There are other users of this code than davinci.  For example, sh
and ARM/shmobile both use it.  Have you verified that your changes will
work for them too?

Rafael


> diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
> index eb78e96..9d8fde7 100644
> --- a/drivers/base/power/clock_ops.c
> +++ b/drivers/base/power/clock_ops.c
> @@ -99,7 +99,7 @@ static void __pm_clk_remove(struct pm_clock_entry *ce)
>  
>  	if (ce->status < PCE_STATUS_ERROR) {
>  		if (ce->status == PCE_STATUS_ENABLED)
> -			clk_disable(ce->clk);
> +			clk_disable_unprepare(ce->clk);
>  
>  		if (ce->status >= PCE_STATUS_ACQUIRED)
>  			clk_put(ce->clk);
> @@ -396,7 +396,7 @@ static void enable_clock(struct device *dev, const char *con_id)
>  
>  	clk = clk_get(dev, con_id);
>  	if (!IS_ERR(clk)) {
> -		clk_enable(clk);
> +		clk_prepare_enable(clk);
>  		clk_put(clk);
>  		dev_info(dev, "Runtime PM disabled, clock forced on.\n");
>  	}
> @@ -413,7 +413,7 @@ static void disable_clock(struct device *dev, const char *con_id)
>  
>  	clk = clk_get(dev, con_id);
>  	if (!IS_ERR(clk)) {
> -		clk_disable(clk);
> +		clk_disable_unprepare(clk);
>  		clk_put(clk);
>  		dev_info(dev, "Runtime PM disabled, clock forced off.\n");
>  	}
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/