linux-kernel - Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1209182255500.4747@utopia.booyaka.com>
Date:	Tue, 18 Sep 2012 22:57:08 +0000 (UTC)
From:	Paul Walmsley <paul@...an.com>
To:	Felipe Balbi <balbi@...com>, khilman@...com
cc:	Sourav Poddar <sourav.poddar@...com>, gregkh@...uxfoundation.org,
	alan@...ux.intel.com, tony@...mide.com, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, santosh.shilimkar@...com
Subject: Re: [RFT/PATCH] serial: omap: prevent resume if device is not
 suspended.

On Tue, 18 Sep 2012, Felipe Balbi wrote:

> On Tue, Sep 18, 2012 at 06:10:50PM +0530, Sourav Poddar wrote:
> > Greg's tty-next is not booting on 2420 based N800. The failure is
> > observed at serial init itself. The reason might be that n800 tries to
> > resume even though it is not suspended before.
> > 
> > Reported-by: Paul Walmsley <paul@...an.com>
> > Signed-off-by: Sourav Poddar <sourav.poddar@...com>
> 
> FWIW:
> 
> Reviewed-by: Felipe Balbi <balbi@...com>
> 
> Paul does this fix the issue for you ? Note that it depends on a
> previous patch Sourav sent [1]
> 
> [1] http://marc.info/?l=linux-omap&m=134796819607889&w=2

Yes, thanks - that fixes it,

Tested-by: Paul Walmsley <paul@...an.com>

> There's one thing that gets my attention, though, why only n800 would
> fail here ?
> 
> I wonder if we should be using:
> 
> pm_runtime_set_active(dev);
> pm_runtime_get_enable(dev);
> 
> to prevent our runtime_resume() to be called from probe, but Sourav
> tested and it doesn't work on BeagleBoard, but it works on PandaBoard.
> 
> Does it ring any bell ??

Nothing off the top of my head but haven't looked into it -- maybe this 
rings a bell with Kevin?


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/