linux-kernel - Re: [PATCH v2 4/9] net/macb: remove macb_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1348067454.4836.56.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 19 Sep 2012 16:10:54 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
CC:	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	<havard@...nnemoen.net>, <linux-arm-kernel@...ts.infradead.org>,
	<plagnioj@...osoft.com>, <patrice.vilchez@...el.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/9] net/macb: remove macb_get_drvinfo()

On Wed, 2012-09-19 at 13:55 +0200, Nicolas Ferre wrote:
> This function has little meaning so remove it altogether and
> let ethtool core fill in the fields automatically.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>
Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>
> ---
>  drivers/net/ethernet/cadence/macb.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 2948553..31f945c 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1217,20 +1217,9 @@ static int macb_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
>  	return phy_ethtool_sset(phydev, cmd);
>  }
>  
> -static void macb_get_drvinfo(struct net_device *dev,
> -			     struct ethtool_drvinfo *info)
> -{
> -	struct macb *bp = netdev_priv(dev);
> -
> -	strcpy(info->driver, bp->pdev->dev.driver->name);
> -	strcpy(info->version, "$Revision: 1.14 $");
> -	strcpy(info->bus_info, dev_name(&bp->pdev->dev));
> -}
> -
>  static const struct ethtool_ops macb_ethtool_ops = {
>  	.get_settings		= macb_get_settings,
>  	.set_settings		= macb_set_settings,
> -	.get_drvinfo		= macb_get_drvinfo,
>  	.get_link		= ethtool_op_get_link,
>  };
>  

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/