[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120919164625.GQ1560@cmpxchg.org>
Date: Wed, 19 Sep 2012 12:46:25 -0400
From: Johannes Weiner <hannes@...xchg.org>
To: Hugh Dickins <hughd@...gle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Mel Gorman <mel@....ul.ie>, Rik van Riel <riel@...hat.com>,
Michel Lespinasse <walken@...gle.com>,
Ying Han <yinghan@...gle.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] mm: remove vma arg from page_evictable
On Tue, Sep 18, 2012 at 08:53:45PM -0700, Hugh Dickins wrote:
> page_evictable(page, vma) is an irritant: almost all its callers pass
> NULL for vma. Remove the vma arg and use mlocked_vma_newpage(vma, page)
> explicitly in the couple of places it's needed. But in those places we
> don't even need page_evictable() itself! They're dealing with a freshly
> allocated anonymous page, which has no "mapping" and cannot be mlocked yet.
>
> Signed-off-by: Hugh Dickins <hughd@...gle.com>
> Cc: Mel Gorman <mel@....ul.ie>
> Cc: Rik van Riel <riel@...hat.com>
> Cc: Johannes Weiner <hannes@...xchg.org>
> Cc: Michel Lespinasse <walken@...gle.com>
> Cc: Ying Han <yinghan@...gle.com>
Much better. With documentation updates and everything, thank you!
Acked-by: Johannes Weiner <hannes@...xchg.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists