linux-kernel - Re: [PATCH] poweroff: fix bug in orderly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKP-df8SrWD-ActWExWBRqJaajQ=5BKiRgHp8tvk3EA_w@mail.gmail.com>
Date:	Tue, 18 Sep 2012 20:42:44 -0700
From:	Kees Cook <keescook@...omium.org>
To:	hongfeng <hongfeng@...vell.com>
Cc:	akpm@...ux-foundation.org, gorcunov@...nvz.org,
	serge.hallyn@...onical.com, ebiederm@...ssion.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] poweroff: fix bug in orderly_poweroff

On Tue, Sep 18, 2012 at 8:27 PM, hongfeng <hongfeng@...vell.com> wrote:
> orderly_poweroff is trying to poweroff platform by two steps:
> step 1: Call userspace application to poweroff
> step 2: If userspace poweroff fail, then do a force power off if force param is set.
>
> The bug here is, step 1 is always successful with param UMH_NO_WAIT,
> should change to UMH_WAIT_PROC which will monitor the return value ofuserspace application.
>
> Signed-off-by: Feng Hong <hongfeng@...vell.com>

Seems right to me.

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/