linux-kernel - RE: [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 Sep 2012 08:59:16 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Doug Anderson' <dianders@...omium.org>,
	'Daniel Kurtz' <djkurtz@...omium.org>
Cc:	'Russell King' <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	'Thomas Abraham' <thomas.abraham@...aro.org>,
	olofj@...omium.org
Subject: RE: [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15

Doug Anderson wrote:
> 
> On Thu, Sep 6, 2012 at 8:21 AM, Daniel Kurtz <djkurtz@...omium.org> wrote:
> > chained_irq_enter/exit() already mask&ack/unmask the chained interrupt.
> > There is no need to also explicitly do it in the handler.
> >
> > Signed-off-by: Daniel Kurtz <djkurtz@...omium.org>
> > ---
> >  arch/arm/mach-exynos/common.c |    7 -------
> >  1 files changed, 0 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-
> exynos/common.c
> > index 4eb39cd..0a85aec 100644
> > --- a/arch/arm/mach-exynos/common.c
> > +++ b/arch/arm/mach-exynos/common.c
> > @@ -965,14 +965,7 @@ static void exynos_irq_eint0_15(unsigned int irq,
> struct irq_desc *desc)
> >         struct irq_chip *chip = irq_get_chip(irq);
> >
> >         chained_irq_enter(chip, desc);
> > -       chip->irq_mask(&desc->irq_data);
> > -
> > -       if (chip->irq_ack)
> > -               chip->irq_ack(&desc->irq_data);
> > -
> >         generic_handle_irq(*irq_data);
> > -
> > -       chip->irq_unmask(&desc->irq_data);
> >         chained_irq_exit(chip, desc);
> >  }
> >
> > --
> > 1.7.7.3
> >
> 
> Acked-by: Doug Anderson <dianders@...omium.org>

Yes, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/