linux-kernel - Re: [PATCH 1/1] audit: Use a tracepoint for getname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120920071008.GB2042@gmail.com>
Date:	Thu, 20 Sep 2012 09:10:08 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Al Viro <viro@...iv.linux.org.uk>, Eric Paris <eparis@...hat.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] audit: Use a tracepoint for getname


* Arnaldo Carvalho de Melo <acme@...stprotocols.net> wrote:

> Al, Eric,
> 
> 	Was this considered before? Acceptable?
> 
> - Arnaldo
> 
> ---
> 
> Instead of an explicit hook only for audit, use a tracepoint, so that
> other users that need to know about filenames can hook there just like
> audit.
> 
> Based on an earlier patch by Thomas Gleixner that added the tracepoint
> but left the audit_getname call.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  fs/namei.c                 |    5 ++++-
>  include/linux/audit.h      |    6 +-----
>  include/trace/events/vfs.h |   32 ++++++++++++++++++++++++++++++++
>  init/Kconfig               |    2 +-
>  kernel/audit.c             |   11 +++++++++++
>  5 files changed, 49 insertions(+), 7 deletions(-)
>  create mode 100644 include/trace/events/vfs.h

Nice generalization and we gain a useful tracepoint as well.

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/