linux-kernel - Re: [PATCH 4/6] xfrm_user: fix info leak in copy_to_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120920072608.GB4221@secunet.com>
Date:	Thu, 20 Sep 2012 09:26:08 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Mathias Krause <minipli@...glemail.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Brad Spengler <spender@...ecurity.net>
Subject: Re: [PATCH 4/6] xfrm_user: fix info leak in copy_to_user_tmpl()

On Wed, Sep 19, 2012 at 11:33:41PM +0200, Mathias Krause wrote:
> The memory used for the template copy is a local stack variable. As
> struct xfrm_user_tmpl contains multiple holes added by the compiler for
> alignment, not initializing the memory will lead to leaking stack bytes
> to userland. Add an explicit memset(0) to avoid the info leak.
> 
> Initial version of the patch by Brad Spengler.
> 
> Cc: Brad Spengler <spender@...ecurity.net>
> Signed-off-by: Mathias Krause <minipli@...glemail.com>

Patches 1-4:

Acked-by: Steffen Klassert <steffen.klassert@...unet.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/