linux-kernel - RE: [PATCHv3] remoteproc: Add STE modem driver for remoteproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 Sep 2012 12:15:23 +0200
From:	Sjur BRENDELAND <sjur.brandeland@...ricsson.com>
To:	Ohad Ben-Cohen <ohad@...ery.com>
Cc:	Sjur Brændeland <sjurbren@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: RE: [PATCHv3] remoteproc: Add STE modem driver for remoteproc

Hi Ohad,

> > +       /* Provide callbacks to modem device */
> > +       mdev->drv_ops = &sproc_drv_ops;
> 
> Implicitly providing the modem with drv_ops and drv_data in this
> manner feels racy and somewhat error prone.
> 
> E.g., on remove these members are set to NULL, under the assumption
> that the modem won't invoke sproc_kick_callback or access sproc
> anymore, but this doesn't feel safe.
> 
> Any chance you can add an explicit registration method to
> ste_modem_dev_ops, with which you'll be able to explicitly set/unset
> sproc_kick_callback and sproc ?

Good point. I'll make a respin fixing this.

Thanks,
Sjur
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/