linux-kernel - Re: [PATCH 01/25] userns: Convert fat to use kuid/kgid where appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ipb8x4id.fsf@devron.myhome.or.jp>
Date:	Thu, 20 Sep 2012 21:28:26 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	ebiederm@...ssion.com (Eric W. Biederman)
Cc:	<linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Serge Hallyn <serge@...lyn.com>,
	Linux Containers <containers@...ts.linux-foundation.org>
Subject: Re: [PATCH 01/25] userns: Convert fat to use kuid/kgid where appropriate

ebiederm@...ssion.com (Eric W. Biederman) writes:

>> I'm not reading this thread, so I may be wrong though. Doesn't this need
>> to initialize opts->fs_uid/fs_gid by GLOBAL_ROOT_UID/GID?
>
> Good question.
>
> At the start of parse_options there is:
>
> static int parse_options(struct super_block *sb, char *options, int is_vfat,
> 			 int silent, int *debug, struct fat_mount_options *opts)
> {
> 	char *p;
> 	substring_t args[MAX_OPT_ARGS];
> 	int option;
> 	char *iocharset;
>
> 	opts->isvfat = is_vfat;
>
> 	opts->fs_uid = current_uid();
> 	opts->fs_gid = current_gid();
>
> So there should be no problems with initialization.

I see.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/