linux-kernel - Fix bug in end absolute address in drivers/mtd/devices/slram.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHODtZTFP=KJh1VmBvCcYLWD=M41vBnf_nyoEbvHKW1UzYx8dQ@mail.gmail.com>
Date:	Thu, 20 Sep 2012 15:48:04 +0200
From:	Jiri Engelthaler <engycz@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: Fix bug in end absolute address in drivers/mtd/devices/slram.c

Hello.
  I found a bug in parsing end absolute address in
drivers/mtd/devices/slram.c. There is checking for startaddress <
endaddress and endaddress subtracted by startaddress before check. The
bug is there from commit 3afd522de8d8ec446efe957b86e4f63e3dd8ce9d Mon,
19 Jan 2009 01:24:21 +0000

Here is the patch

Signed-off-by: Jiri Engelthaler <engycz@...il.com>

--- linux-3.2.28/drivers/mtd/devices/slram.c	2012-08-19 19:15:38.000000000 +0200
+++ linux-3.2.28.mod/drivers/mtd/devices/slram.c	2012-09-19
18:29:28.012740703 +0200
@@ -266,7 +266,7 @@ static int parse_cmdline(char *devname,

 	if (*(szlength) != '+') {
 		devlength = simple_strtoul(szlength, &buffer, 0);
-		devlength = handle_unit(devlength, buffer) - devstart;
+		devlength = handle_unit(devlength, buffer);
 		if (devlength < devstart)
 			goto err_out;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/