linux-kernel - Re: [PATCH 1/2] drivers/s390/char/monreader.c: fix error return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120920164001.50a4305c@thinkpad>
Date:	Thu, 20 Sep 2012 16:40:01 +0200
From:	Gerald Schaefer <gerald.schaefer@...ibm.com>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
	linux390@...ibm.com, linux-s390@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] drivers/s390/char/monreader.c: fix error return
 code

On Mon, 17 Sep 2012 10:12:00 +0200
Peter Senna Tschudin <peter.senna@...il.com> wrote:

> From: Peter Senna Tschudin <peter.senna@...il.com>
> 
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
> // </smpl>
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---
>  drivers/s390/char/monreader.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/char/monreader.c b/drivers/s390/char/monreader.c
> index 5b8b859..f4ff515 100644
> --- a/drivers/s390/char/monreader.c
> +++ b/drivers/s390/char/monreader.c
> @@ -571,8 +571,11 @@ static int __init mon_init(void)
>  	if (rc)
>  		goto out_iucv;
>  	monreader_device = kzalloc(sizeof(struct device), GFP_KERNEL);
> -	if (!monreader_device)
> +	if (!monreader_device) {
> +		rc = -ENOMEM;
>  		goto out_driver;
> +	}
> +
>  	dev_set_name(monreader_device, "monreader-dev");
>  	monreader_device->bus = &iucv_bus;
>  	monreader_device->parent = iucv_root;

Applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/