linux-kernel - Re: [PATCH 1/1] audit: Use a tracepoint for getname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120920151136.GD11325@ghostprotocols.net>
Date:	Thu, 20 Sep 2012 08:11:36 -0700
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Eric Paris <eparis@...hat.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	jlayton@...hat.com
Subject: Re: [PATCH 1/1] audit: Use a tracepoint for getname

Em Thu, Sep 20, 2012 at 09:05:45AM -0400, Eric Paris escreveu:
> cc'ing Jeff Layton who has recently done a lot of getname work and I
> want to make sure he sees this.

Thanks, will try with his patchset applied, but see below...
 
> On Wed, 19 Sep 2012 15:56:59 -0700
> Arnaldo Carvalho de Melo <acme@...stprotocols.net> wrote:
> > @@ -978,6 +986,9 @@ static int __init audit_init(void)
> >  	else
> >  		audit_sock->sk_sndtimeo = MAX_SCHEDULE_TIMEOUT;
> >  
> > +	if (register_trace_getname(audit_getname, NULL))
> > +		audit_panic("cannot register getname tracepoint");
> > +
> >  	skb_queue_head_init(&audit_skb_queue);
> >  	skb_queue_head_init(&audit_skb_hold_queue);
> >  	audit_initialized = AUDIT_INITIALIZED;
> 
> I think we need to just use panic instead of audit_panic.  This early

I don't have an opinion on that matter, just used what is done on the 'true'
part of that other else, some lines above the register_trace_getname if:

        audit_sock = netlink_kernel_create(&init_net, NETLINK_AUDIT,
                                           THIS_MODULE, &cfg);
        if (!audit_sock)
                audit_panic("cannot initialize netlink socket");
        else
                audit_sock->sk_sndtimeo = MAX_SCHEDULE_TIMEOUT;

> at boot userspace would not have been able to tell the kernel that
> audit_panic == panic nor would the box die later if userspace ask for
> that functionality.  Instead the box would run but audit would be

But then why audit_panic is called when netlink_kernel_create fails?

> broken, which customers who want audit_panic == panic would be most
> upset about.
> 
> Otherwise, its good to me.

Thanks!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/