lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 20 Sep 2012 15:02:04 -0700
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	walter harms <wharms@....de>,
	Ashish Jangam <ashish.jangam@...tcummins.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] da9052-battery: don't free IRQ that wasn't requested

On Thu, Sep 06, 2012 at 08:07:58AM -0700, Dan Carpenter wrote:
[...]
> >    for (j=0; j <= i ;j++ ) {
>                ^^^^^^
> The count up loops are prone to the exact same off by one bugs.  ;)
> You've got one in your sample code.  Plus I'd have to declare
> another variable and send a v2 patch and I am very lazy...  So in
> this case I think should just take my original patch.

Applied, thank you!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ