linux-kernel - Re: [PATCH v2 06/26] block: Use bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120920234713.GF5519@google.com>
Date:	Thu, 20 Sep 2012 16:47:14 -0700
From:	Kent Overstreet <koverstreet@...gle.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org,
	dm-devel@...hat.com, axboe@...nel.dk, neilb@...e.de
Subject: Re: [PATCH v2 06/26] block: Use bio_sectors() more consistently

On Thu, Sep 20, 2012 at 04:36:18PM -0700, Tejun Heo wrote:
> On Mon, Sep 10, 2012 at 05:22:17PM -0700, Kent Overstreet wrote:
> > diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
> > index 321de7b..6e4420a 100644
> > --- a/drivers/block/aoe/aoeblk.c
> > +++ b/drivers/block/aoe/aoeblk.c
> > @@ -199,7 +199,7 @@ aoeblk_make_request(struct request_queue *q, struct bio *bio)
> >  	buf->bio = bio;
> >  	buf->resid = bio->bi_size;
> >  	buf->sector = bio->bi_sector;
> > -	buf->bv = &bio->bi_io_vec[bio->bi_idx];
> > +	buf->bv = bio_iovec(bio);
> 
> Contamination?

Whoops, yes.

> Also, in general, please cc at least the maintainers of the files that
> you modify.

Meant to ask you about these patches that basically just rename things -
will do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/