linux-kernel - Re: [PATCH 5/5] charger-manager: Support limit of maximum possible duration for charging/discharging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120921050837.GA927@lizard>
Date:	Thu, 20 Sep 2012 22:08:38 -0700
From:	Anton Vorontsov <anton.vorontsov@...aro.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	jenny.tc@...el.com, ramakrishna.pallala@...el.com,
	myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] charger-manager: Support limit of maximum possible
 duration for charging/discharging

On Tue, Aug 21, 2012 at 05:06:57PM +0900, Chanwoo Choi wrote:
> This patch check maximum possible duration of charging/discharging.
> 
> If whole charging duration exceed 'desc->charging_max_duration_ms',
> cm stop charging to prevent overcharge/overheat. And if discharging
> duration exceed, charger cable is attached, after full-batt,
> cm start charging to maintain fully charged state for battery.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> Signed-off-by: Myungjoo Ham <myungjoo.ham@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> ---

Applied, thanks!

But fyi:

[...]
> +	if (!desc->charging_max_duration_ms
> +		&& !desc->discharging_max_duration_ms)

&& should have been on the previous line, plus the second line
should have been indented with one more tab. I fixed it up.

[...]
> +	if (!desc->charging_max_duration_ms
> +		|| !desc->discharging_max_duration_ms) {

Ditto.

> +		dev_info(&pdev->dev, "Cannot limit charging duration"
> +				" checking mechanism to prevent "
> +				" overcharge/overheat and control"

Thanks,
Anton.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/