linux-kernel - Re: mm: frontswap: fix a wrong if condition in frontswap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120921072359.GB13767@mwanda>
Date:	Fri, 21 Sep 2012 10:23:59 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Zhenzhong Duan <zhenzhong.duan@...cle.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mm@...ck.org, Dan Magenheimer <dan.magenheimer@...cle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	levinsasha928@...il.com, Feng Jin <joe.jin@...cle.com>
Subject: Re: mm: frontswap: fix a wrong if condition in frontswap_shrink

On Fri, Sep 21, 2012 at 11:29:56AM +0800, Zhenzhong Duan wrote:
> pages_to_unuse is set to 0 to unuse all frontswap pages
> But that doesn't happen since a wrong condition in frontswap_shrink
> cancels it.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...cle.com>
> ---
>  mm/frontswap.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/frontswap.c b/mm/frontswap.c
> index 6b3e71a..db2a86f 100644
> --- a/mm/frontswap.c
> +++ b/mm/frontswap.c
> @@ -275,7 +275,7 @@ static int __frontswap_shrink(unsigned long target_pages,
>  	if (total_pages <= target_pages) {
>  		/* Nothing to do */
>  		*pages_to_unuse = 0;
> -		return 0;
> +		return 1;
>  	}

This function used to return 0 or an error code.  Could we add a
comment at the top saying what the return values mean.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/