linux-kernel - Re: [PATCH] pda_power: ac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120921002037.GA31075@lizard>
Date:	Thu, 20 Sep 2012 17:20:37 -0700
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Paul Parsons <lost.distance@...oo.com>
Cc:	dwmw2@...radead.org, philipp.zabel@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pda_power: ac_draw used before set

On Fri, Sep 21, 2012 at 01:16:38AM +0100, Paul Parsons wrote:
> >>When I reboot my iPAQ hx4700 in its cradle, the battery will not begin
> >>to charge even though the AC supply is connected. Charging will start
> >>only after the PDA power driver is tickled by some other power event,
> >>such as reseating the iPAQ in its cradle or connecting the USB cable.
> >>
> >>The problem lies in pda_power_probe(), where ac_draw is used by the call
> >>to update_charger() before being set by the call to regulator_get().
> >>
> >>Moving the regulator_get() call to before the update_charger() call
> >>fixes the problem.
> >>
> >>Signed-off-by: Paul Parsons <lost.distance@...oo.com>
> >>Cc: Philipp Zabel <philipp.zabel@...il.com>
> >>---
> >
> >Great to see that someone is still using hx4700. :-)
> >
> >Thanks for the patch, it is merged now!
> 
> I am having second thoughts about the goto ac_draw_failed I added.
> This will cause pda_power_probe() to fail if regulator_get() fails.
> However the way ac_draw is used - always after a check for NULL -
> suggests that a failed call to regulator_get() was not fatal.
> 
> I am happy to submit another patch to remove the goto and label.

Sure thing, just send another patch on top.

Thanks!
Anton.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/