| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120921000456.GI5519@google.com> Date: Thu, 20 Sep 2012 17:04:57 -0700 From: Kent Overstreet <koverstreet@...gle.com> To: Tejun Heo <tj@...nel.org> Cc: linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org, dm-devel@...hat.com, axboe@...nel.dk, neilb@...e.de Subject: Re: [PATCH v2 08/26] block: Remove bi_idx references On Thu, Sep 20, 2012 at 04:49:53PM -0700, Tejun Heo wrote: > On Mon, Sep 10, 2012 at 05:22:19PM -0700, Kent Overstreet wrote: > > These were harmless but uneccessary,andt getting rid of them makes the > > code easier to audit since most of them need to be removed. > > I find the descriptions a bit too terse. Why do they need to be > removed? So, I suppose you wanted to say explicit initializations to > 0 are unnecessary, but there are bio_segments() conversions too. > > The patch is simple and this isn't a big deal but I really hope for > better (correct) descriptions. It's because for the bvec iterator stuff and immutable bvecs, direct bi_idx usage tends to be either wrong or unnecessary - I had to audit all the uses in the kernel. Reason for doing it now is a later patch moves bi_idx (also bi_sector and bi_size) into a different struct - so doing these cleanup patches first means a bit less code churn. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists