linux-kernel - Re: Query of zram/zsmalloc promotion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 21 Sep 2012 20:31:37 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Konrad Rzeszutek Wilk <konrad@...nel.org>
CC:	Minchan Kim <minchan@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Nitin Gupta <ngupta@...are.org>,
	Seth Jennings <sjenning@...ux.vnet.ibm.com>,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	Konrad Rzeszutek Wilk <konrad@...nok.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: Query of zram/zsmalloc promotion

On 2012-09-21 18:41, Konrad Rzeszutek Wilk wrote:
> On Wed, Sep 12, 2012 at 11:39:14AM +0900, Minchan Kim wrote:
>> Hi all,
>>
>> I would like to promote zram/zsmalloc from staging tree.
>> I already tried it https://lkml.org/lkml/2012/8/8/37 but I didn't get
>> any response from you guys.
>>
>> I think zram/zsmalloc's code qulity is good and they
>> are used for many embedded vendors for a long time.
>> So it's proper time to promote them.
>>
>> The zram should put on under driver/block/. I think it's not
>> arguable but the issue is which directory we should keep *zsmalloc*.
>>
>> Now Nitin want to keep it with zram so it would be in driver/blocks/zram/
>> But I don't like it because zsmalloc touches several fields of struct page
>> freely(and AFAIRC, Andrew had a same concern with me) so I want to put
>> it under mm/.
> 
> I like the idea of keeping it in /lib or /mm. Actually 'lib' sounds more
> appropriate since it is dealing with storing a bunch of pages in a nice
> layout for great density purposes.
>>
>> In addtion, now zcache use it, too so it's rather awkward if we put it
>> under dirver/blocks/zram/.
>>
>> So questions.
>>
>> To Andrew:
>> Is it okay to put it under mm/ ? Or /lib?
>>
>> To Jens:
>> Is it okay to put zram under drvier/block/ If you are okay, I will start sending
>> patchset after I sort out zsmalloc's location issue.
> 
> I would think it would be OK.

We can certainly put it in drivers/block, I have no issue with that.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/