linux-kernel - Re: [PATCH v2 0/3] input: Dynamic Minor Numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2737921.JXTsrgJ0N6@dtor-d630.eng.vmware.com>
Date:	Fri, 21 Sep 2012 13:51:30 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	David Herrmann <dh.herrmann@...glemail.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] input: Dynamic Minor Numbers

On Friday, September 21, 2012 09:18:00 PM David Herrmann wrote:
> Hi Dmitry
> 
> On Fri, Sep 21, 2012 at 11:22 AM, David Herrmann
> 
> <dh.herrmann@...glemail.com> wrote:
> > Hi Dmitry
> > 
> > On Fri, Sep 21, 2012 at 10:07 AM, Dmitry Torokhov
> > 
> > <dmitry.torokhov@...il.com> wrote:
> >> Thank you very much for working on this, unfortunately your patch extends
> >> the existing infrastructure handling of character devices in input core,
> >> which is quite rigid and sub-optimal.
> >> 
> >> For a while now I wanted to stop input core from pre-creating character
> >> devices and multiplexing file operations and instead push more chardev
> >> handling tasks into individual input handlers and make they more
> >> independent from input core. So while I won't be taking your patch as is
> >> it was a great motivator to finally do something about current
> >> limitation and I would appreciate if you could take a look at the patch
> >> below and see if you have any issues with it.
> > 
> > I didn't know why we did that, anyway. But I tried to keep that logic,
> > even though it is really weird. So I am quite glad that you fixed it.
> 
> Sorry, compiling a kernel takes 44m here so I haven't had time earlier
> this day. But I just recompiled with your patch and it works like a
> charm. I have attached output of "ls -la /dev/input" with 900 uinput
> devices. Performance does suck but that is definitely another issue.

Could you elaborate a bit on this?

> 
> So here's my:
> Tested-by: David Herrmann <dh.herrmann@...glemail.com>

Thanks for testing!

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/