linux-kernel - Re: [PATCH v3 17/17] ARM: mm: clean up membank size limit checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <505CEEF6.1050205@ti.com>
Date:	Fri, 21 Sep 2012 18:49:26 -0400
From:	Cyril Chemparathy <cyril@...com>
To:	Nicolas Pitre <nicolas.pitre@...aro.org>
CC:	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <arnd@...db.de>,
	<catalin.marinas@....com>, <grant.likely@...retlab.ca>,
	<linux@....linux.org.uk>, <will.deacon@....com>,
	Vitaly Andrianov <vitalya@...com>
Subject: Re: [PATCH v3 17/17] ARM: mm: clean up membank size limit checks

On 9/21/2012 2:42 PM, Nicolas Pitre wrote:
> On Tue, 11 Sep 2012, Cyril Chemparathy wrote:
>
>> This patch cleans up the highmem sanity check code by simplifying the range
>> checks with a pre-calculated size_limit.  This patch should otherwise have no
>> functional impact on behavior.
>>
>> This patch also removes a redundant (bank->start < vmalloc_limit) check, since
>> this is already covered by the !highmem condition.
>>
>> Signed-off-by: Cyril Chemparathy <cyril@...com>
>> Signed-off-by: Vitaly Andrianov <vitalya@...com>
>
> Acked-by: Nicolas Pitre <nico@...aro.org>
>

Thanks, Nico.

Could you please take another peek at patch 05/17 (support 64-bit 
virt_to_phys patching)?  You had reviewed it in an earlier posting, but 
I've had to tweak the code to optimize the compiler generated inline 
expansion code.

Patch 14/17 (accomodate >32-bit addresses for page table base) could use 
some attention as well.  The same goes with 12/17 (define 
ARCH_LOW_ADDRESS_LIMIT for bootmem), if you could.

-- 
Thanks
- Cyril
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/