linux-kernel - Re: [PATCH v2 2/5] unicore32: pwm: Use module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50847.162.105.203.8.1348282590.squirrel@mprc.pku.edu.cn>
Date:	Sat, 22 Sep 2012 10:56:30 +0800 (CST)
From:	guanxuetao@...c.pku.edu.cn
To:	"Thierry Reding" <thierry.reding@...onic-design.de>
Cc:	"Guan Xuetao" <gxt@...c.pku.edu.cn>,
	"Qin Rui" <qinrui@...c.pku.edu.cn>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] unicore32: pwm: Use module_platform_driver()

> Some of the boilerplate code can be eliminated by using this macro. The
> driver was previously registered with an arch_initcall(), so technically
> this is no longer the same, but when the driver is moved to the PWM
> framework, deferred probing will take care of any driver probe ordering
> issues.
>
> Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de>

Tested-by: Qin Rui <qinrui@...c.pku.edu.cn>
Acked-by: Guan Xuetao <gxt@...c.pku.edu.cn>

Thanks & Regards,
Guan Xuetao

> ---
>  arch/unicore32/kernel/pwm.c | 21 +--------------------
>  1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/arch/unicore32/kernel/pwm.c b/arch/unicore32/kernel/pwm.c
> index 885bbcd..012c54a 100644
> --- a/arch/unicore32/kernel/pwm.c
> +++ b/arch/unicore32/kernel/pwm.c
> @@ -254,25 +254,6 @@ static struct platform_driver puv3_pwm_driver = {
>  	.probe		= puv3_pwm_probe,
>  	.remove		= __devexit_p(pwm_remove),
>  };
> -
> -static int __init pwm_init(void)
> -{
> -	int ret = 0;
> -
> -	ret = platform_driver_register(&puv3_pwm_driver);
> -	if (ret) {
> -		printk(KERN_ERR "failed to register puv3_pwm_driver\n");
> -		return ret;
> -	}
> -
> -	return ret;
> -}
> -arch_initcall(pwm_init);
> -
> -static void __exit pwm_exit(void)
> -{
> -	platform_driver_unregister(&puv3_pwm_driver);
> -}
> -module_exit(pwm_exit);
> +module_platform_driver(puv3_pwm_driver);
>
>  MODULE_LICENSE("GPL v2");
> --
> 1.7.12
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/