[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <505F643C.3020203@redhat.com>
Date: Sun, 23 Sep 2012 16:34:20 -0300
From: Mauro Carvalho Chehab <mchehab@...hat.com>
To: Guennadi Liakhovetski <g.liakhovetski@....de>
CC: kernel-janitors@...r.kernel.org, Julia.Lawall@...6.fr,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
Peter Senna Tschudin <peter.senna@...il.com>
Subject: Fwd: [PATCH 1/14] drivers/media/platform/soc_camera/soc_camera.c:
fix error return code
Please review.
Please review.
Regards,
Mauro.
-------- Mensagem original --------
Assunto: [PATCH 1/14] drivers/media/platform/soc_camera/soc_camera.c: fix error return code
Data: Thu, 6 Sep 2012 17:24:00 +0200
De: Peter Senna Tschudin <peter.senna@...il.com>
Para: Mauro Carvalho Chehab <mchehab@...radead.org>
CC: kernel-janitors@...r.kernel.org, Julia.Lawall@...6.fr, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
From: Peter Senna Tschudin <peter.senna@...il.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>
---
drivers/media/platform/soc_camera/soc_camera.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c
index 10b57f8..a4beb6c 100644
--- a/drivers/media/platform/soc_camera/soc_camera.c
+++ b/drivers/media/platform/soc_camera/soc_camera.c
@@ -1184,7 +1184,8 @@ static int soc_camera_probe(struct soc_camera_device *icd)
sd->grp_id = soc_camera_grp_id(icd);
v4l2_set_subdev_hostdata(sd, icd);
- if (v4l2_ctrl_add_handler(&icd->ctrl_handler, sd->ctrl_handler))
+ ret = v4l2_ctrl_add_handler(&icd->ctrl_handler, sd->ctrl_handler);
+ if (ret)
goto ectrl;
/* At this point client .probe() should have run already */
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
View attachment "Seção da mensagem anexada" of type "text/plain" (0 bytes)
Powered by blists - more mailing lists