linux-kernel - RE: [PATCH] Thermal: Fix bug on generic thermal framework.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1348477068.10877.180.camel@rui.sh.intel.com>
Date:	Mon, 24 Sep 2012 16:57:48 +0800
From:	Zhang Rui <rui.zhang@...el.com>
To:	"R, Durgadoss" <durgadoss.r@...el.com>
Cc:	Jonghwa Lee <jonghwa3.lee@...sung.com>,
	"linux-pml@...r.kernel.org" <linux-pml@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Brown, Len" <len.brown@...el.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Amit Kachhap <amit.kachhap@...aro.org>
Subject: RE: [PATCH] Thermal: Fix bug on generic thermal framework.

On 一, 2012-09-24 at 02:08 -0600, R, Durgadoss wrote:
> Hi,
> 
> Patch is fine, but I think you have to re-base on top of
> Rui's -next branch here:
> git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git
> 
> Also, adding Rui to this mail, not sure whether he is in LKML/pm.
> 
> Thanks,
> Durga
> 
> > -----Original Message-----
> > From: Jonghwa Lee [mailto:jonghwa3.lee@...sung.com]
> > Sent: Monday, September 24, 2012 7:36 AM
> > To: linux-pml@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org; Brown, Len; Rafael J. Wysocki; Andrew
> > Morton; Amit Kachhap; R, Durgadoss; Jonghwa Lee
> > Subject: [PATCH] Thermal: Fix bug on generic thermal framework.
> > 
> > When system fails to bind cooling devices to thermal zone device during
> > registering thermal zone device, it leaves registering without canceling
> > delayed work. It probably makes panic if polling rate is not enough to release
> > that work from workqueue. So it is better to ignore initialization of polling
> > work to prevent that unexpected state.
> > 
Hi, Jonghwa,

I still do not understand what the problem is.
Say if a cooling device fails to bind, the thermal zone device would
still work properly, just like the failure cooling device is not
referenced in this thermal zone.

thanks,
rui
> > Signed-off-by: Jonghwa Lee <jonghwa3.lee@...sung.com>
> > ---
> >  drivers/thermal/thermal_sys.c |    6 ++++--
> >  1 files changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> > index 2ab31e4..744e69d 100644
> > --- a/drivers/thermal/thermal_sys.c
> > +++ b/drivers/thermal/thermal_sys.c
> > @@ -1351,12 +1351,14 @@ struct thermal_zone_device
> > *thermal_zone_device_register(const char *type,
> >  		}
> >  	mutex_unlock(&thermal_list_lock);
> > 
> > +	if (result)
> > +		goto unregister;
> > +
> >  	INIT_DELAYED_WORK(&(tz->poll_queue),
> > thermal_zone_device_check);
> > 
> >  	thermal_zone_device_update(tz);
> > 
> > -	if (!result)
> > -		return tz;
> > +	return tz;
> > 
> >  unregister:
> >  	release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id);
> > --
> > 1.7.4.1
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/