linux-kernel - Re: [PATCH] x86, kprobes: Hide skip_singlestep forward declaration properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <506035D0.6040504@hitachi.com>
Date:	Mon, 24 Sep 2012 19:28:32 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Borislav Petkov <bp@...64.org>, Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>, X86-ML <x86@...nel.org>,
	Borislav Petkov <borislav.petkov@....com>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] x86, kprobes: Hide skip_singlestep forward declaration
 properly

(2012/09/20 18:40), Ingo Molnar wrote:
> 
> * Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:
> 
>> (2012/09/20 18:25), Ingo Molnar wrote:
>>>
>>> * Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:
>>>
>>>> (2012/09/19 22:46), Borislav Petkov wrote:
>>>>> From: Borislav Petkov <borislav.petkov@....com>
>>>>>
>>>>> I get
>>>>>
>>>>> arch/x86/kernel/kprobes.c:544:23: warning: ‘skip_singlestep’ declared ‘static’ but never defined [-Wunused-function]
>>>>>
>>>>> on tip/auto-latest.
>>>>>
>>>>> Hide the forward declaration in the KPROBES_CAN_USE_FTRACE as it
>>>>> is done in its callsites.
>>>>
>>>> Thank you for reporting and fixing :)
>>>
>>> Why is a forward declation needed, why isn't the function in the 
>>> proper spot in the file to begin with?
>>
>> There is no reason, ftrace-related things can also be moved on top.
>> Borislav, could you move it?
> 
> Could be moved into a separate file as well - we could have 
> arch/x86/kprobes/, with core.c, opt.c, ftrace.c and common.h in 
> it - possibly more in the future.

OK, I'll break it into those pieces :)

Thank you,

-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/