linux-kernel - Re: [PATCH] Staging:bcm: fix coding style issue in Bcmchar.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 24 Sep 2012 13:52:26 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Gorskin Ilya <revent82@...il.com>
Cc:	gregkh@...uxfoundation.org, klmckinney1@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:bcm: fix coding style issue in Bcmchar.c

On Mon, Sep 24, 2012 at 04:44:43PM +0600, Gorskin Ilya wrote:
> This is a patch to the Bcmchar.c file that fixes up a coding style
> warning found by the checkpatch.pl tool
> 

The right way to fix this is to choose better variable names and to
get rid of the bogus BCM_DEBUG_PRINT() macro.  It's better to leave
the warnings in for now.

checkpatch.pl is not the king of us.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/