linux-kernel - Re: [PATCH] leds: lm3642: Use regmap_update_bits() in lm3642_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 24 Sep 2012 19:11:22 +0800
From:	Bryan Wu <bryan.wu@...onical.com>
To:	gshark <gshark.jeong@...il.com>
Cc:	Axel Lin <axel.lin@...ics.com>, Richard Purdie <rpurdie@...ys.net>,
	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: lm3642: Use regmap_update_bits() in lm3642_chip_init()

On Mon, Sep 24, 2012 at 8:58 AM, gshark <gshark.jeong@...il.com> wrote:
> 2012Гт 09Пљ 22РЯ 15:40, Axel Lin ОД Бл:
>
>> Use regmap_update_bits() to replace regmap_read() + regmap_write().
>> With this patch, we only show the error message when regmap_update_bits()
>> fails.
>
>     Looks good..You're right.  Thank you Alex.
>>
>>
>> Signed-off-by: Axel Lin <axel.lin@...ics.com>
>
>     Acked-by: G.Shark Jeong<gshark.jeong@...il.com>
>

Thanks, applied to my for-next.

-Bryan


>> ---
>>   drivers/leds/leds-lm3642.c |   15 +++------------
>>   1 file changed, 3 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/leds/leds-lm3642.c b/drivers/leds/leds-lm3642.c
>> index 924853b..3285006 100644
>> --- a/drivers/leds/leds-lm3642.c
>> +++ b/drivers/leds/leds-lm3642.c
>> @@ -95,23 +95,14 @@ struct lm3642_chip_data {
>>   /* chip initialize */
>>   static int __devinit lm3642_chip_init(struct lm3642_chip_data *chip)
>>   {
>> -       unsigned int reg_val;
>>         int ret;
>>         struct lm3642_platform_data *pdata = chip->pdata;
>>         /* set enable register */
>> -       ret = regmap_read(chip->regmap, REG_ENABLE, &reg_val);
>> +       ret = regmap_update_bits(chip->regmap, REG_ENABLE,
>> EX_PIN_ENABLE_MASK,
>> +                                pdata->tx_pin);
>>         if (ret < 0)
>> -               goto out;
>> -
>> -       reg_val &= (~EX_PIN_ENABLE_MASK);
>> -       reg_val |= pdata->tx_pin;
>> -       ret = regmap_write(chip->regmap, REG_ENABLE, reg_val);
>> -       if (ret < 0)
>> -               goto out;
>> -
>> -out:
>> -       dev_err(chip->dev, "Failed to read REG_ENABLE Register\n");
>> +               dev_err(chip->dev, "Failed to update REG_ENABLE
>> Register\n");
>>         return ret;
>>   }
>>
>
>



-- 
Bryan Wu <bryan.wu@...onical.com>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/