linux-kernel - Re: [PATCH v5] media: v4l2-ctrl: add a helper function to add standard control with driver specific menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201209241458.14376.hverkuil@xs4all.nl>
Date:	Mon, 24 Sep 2012 14:58:14 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Prabhakar <prabhakar.csengg@...il.com>
Cc:	LMML <linux-media@...r.kernel.org>,
	DLOS <davinci-linux-open-source@...ux.davincidsp.com>,
	LDOC <linux-doc@...r.kernel.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	VGER <linux-kernel@...r.kernel.org>,
	"Lad, Prabhakar" <prabhakar.lad@...com>,
	Manjunath Hadli <manjunath.hadli@...com>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Sakari Ailus <sakari.ailus@....fi>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Rob Landley <rob@...dley.net>
Subject: Re: [PATCH v5] media: v4l2-ctrl: add a helper function to add standard control with driver specific menu

On Mon September 24 2012 14:53:40 Prabhakar wrote:
> From: Lad, Prabhakar <prabhakar.lad@...com>
> 
> Add helper function v4l2_ctrl_new_std_menu_items(), which adds
> a standard menu control, with driver specific menu.

Acked-by: Hans Verkuil <hans.verkuil@...co.com>

Regards,

	Hans

> 
> Signed-off-by: Lad, Prabhakar <prabhakar.lad@...com>
> Signed-off-by: Manjunath Hadli <manjunath.hadli@...com>
> Cc: Hans Verkuil <hans.verkuil@...co.com>
> Cc: Sakari Ailus <sakari.ailus@....fi>
> Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Cc: Mauro Carvalho Chehab <mchehab@...radead.org>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Kyungmin Park <kyungmin.park@...sung.com>
> Cc: Guennadi Liakhovetski <g.liakhovetski@....de>
> Cc: Rob Landley <rob@...dley.net>
> ---
>  Changes for v5:
>  1: Fixed some grammatical issues pointed by Hans.
> 
>  Changes for v4:
>  1: Rather then adding a function to modify the menu, added a helper
>    function, that creates a new standard control with user specific
>    menu.
> 
>  Changes for v3:
>  1: Fixed style/grammer issues as pointed by Hans.
>    Thanks Hans for providing the description.
> 
>  Changes for v2:
>  1: Fixed review comments from Hans, to have return type as
>    void, add WARN_ON() for fail conditions, allow this fucntion
>    to modify the menu of custom controls.
> 
>  Documentation/video4linux/v4l2-controls.txt |   24 +++++++++++++++++++++
>  drivers/media/v4l2-core/v4l2-ctrls.c        |   30 +++++++++++++++++++++++++++
>  include/media/v4l2-ctrls.h                  |   23 ++++++++++++++++++++
>  3 files changed, 77 insertions(+), 0 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/