linux-kernel - Re: [PATCH 0/2] struct pid-ify autofs4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d31bczo7.fsf@tucsk.pomaz.szeredi.hu>
Date:	Mon, 24 Sep 2012 15:34:32 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Ian Kent <raven@...maw.net>
Cc:	autofs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, sukadev@...ux.vnet.ibm.com,
	serge.hallyn@...onical.com, ebiederm@...ssion.com
Subject: Re: [PATCH 0/2] struct pid-ify autofs4

Ian Kent <raven@...maw.net> writes:

> On Fri, 2012-09-21 at 17:44 +0200, Miklos Szeredi wrote:
>> Miklos Szeredi <miklos@...redi.hu> writes:
>> 
>> > These two patches change autofs4 to store struct pid pointers instead of pid_t
>> > values.
>> >
>> > Fixed various issues with the previous post.  Not tested, handle with
>> > care!
>> 
>> Customer gave positive test results.
>
> For what exactly, there's no problem description in these patches?

>From what I understand (and I'm not an expert by any means) is that
autofs doesn't work if containers are used.  The first patch fixes this.

Both the patches replace pid_t with a refcounted struct pid object,
which has better lifetime properties: you don't know whether a pid_t is
valid, because pid numbers are reused, while pid objects remain valid
until there are no more references to them.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/