linux-kernel - Re: [PATCH 05/14] userns: Convert hostfs to use kuid and kgid where appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120924145534.GA5193@sergelap>
Date:	Mon, 24 Sep 2012 09:55:34 -0500
From:	Serge Hallyn <serge.hallyn@...onical.com>
To:	Richard Weinberger <richard@....at>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Linux Containers <containers@...ts.linux-foundation.org>,
	linux-security-module@...r.kernel.org,
	Jeff Dike <jdike@...toit.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/14] userns: Convert hostfs to use kuid and kgid where
 appropriate

Quoting Richard Weinberger (richard@....at):
> Am 21.09.2012 02:28, schrieb Eric W. Biederman:
> > From: "Eric W. Biederman" <ebiederm@...ssion.com>
> > 
> > Cc: Jeff Dike <jdike@...toit.com>
> > Cc: Richard Weinberger <richard@....at>
> > Acked-by: Serge Hallyn <serge.hallyn@...onical.com>
> > Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
> > ---
> 
> Looks sane to me.
> 
> Acked-by: Richard Weinberger <richard@....at>
> 
> BTW: How you do test your user namespace patches?

I've got a few specific tests of the new functionality in the usernstest.c
in the nsexec package at
https://launchpad.net/~serge-hallyn/+archive/userns-natty/+sourcepub/2530252/+listing-archive-extra .
Of course LTP already has a good set of test cases for the regular
functionality.

> Is there a generic way to compare/verify uids within a namespace vs. the initial namespace?

It's good to look at output of 'id' in the task versus 'ps' from the initial ns,
as well as create a file and look at the stat output from both namespaces.

-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/