linux-kernel - Re: [PATCH] c/r: prctl: fix build error for no-MMU case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Sep 2012 01:55:07 +0400
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	Mark Salter <msalter@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Kees Cook <keescook@...omium.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] c/r: prctl: fix build error for no-MMU case

On Mon, Sep 24, 2012 at 05:41:32PM -0400, Mark Salter wrote:
> Commit 1ad75b9e1 added some address checking to prctl_set_mm()
> used by checkpoint-restore. This causes a build error for no-MMU
> systems:
> 
>    kernel/sys.c: In function 'prctl_set_mm':
>    kernel/sys.c:1868:34: error: 'mmap_min_addr' undeclared (first use in this function)
> 
> The test for mmap_min_addr doesn't make a lot of sense for no-MMU
> code as noted in commit 6e1415467. This patch defines mmap_min_addr
> as 0UL in the no-MMU case so that the compiler will optimize away
> tests for "addr < mmap_min_addr".
> 
> Signed-off-by: Mark Salter <msalter@...hat.com>

Thanks, Mark! I should add that this mmap_min_addr currently
referenced in other parts of code only under CONFIG_MMU so this
definition in header should not break anything.

Reviewed-by: Cyrill Gorcunov <gorcunov@...nvz.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/