linux-kernel - Re: [PATCH 3/3] Staging:bcm: fix coding style error in InterfaceIsr.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120925065351.GQ4587@mwanda>
Date:	Tue, 25 Sep 2012 09:53:52 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Gorskin Ilya <revent82@...il.com>
Cc:	gregkh@...uxfoundation.org, klmckinney1@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Staging:bcm: fix coding style error in InterfaceIsr.c

On Tue, Sep 25, 2012 at 11:04:29AM +0600, Gorskin Ilya wrote:
> This is a patch to the InterfaceIsr.c file that
> fixes up a coding style issues found by the checkpatch.pl tool

I'm afraid all these need to be redone along the lines which I
explained in my other email.

> 
> Signed-off-by: Ilya Gorskin <revent82@...il.com>
> ---
>  drivers/staging/bcm/InterfaceIsr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/bcm/InterfaceIsr.c b/drivers/staging/bcm/InterfaceIsr.c
> index 4f78451..0e68485 100644
> --- a/drivers/staging/bcm/InterfaceIsr.c
> +++ b/drivers/staging/bcm/InterfaceIsr.c
> @@ -120,7 +120,7 @@ static void read_int_callback(struct urb *urb/*, struct pt_regs *regs*/)
>  			urb->status = STATUS_SUCCESS ;
>  			break ;
>  			/*return;*/
> -		default:
> +	default:
>  			/*This is required to check what is the defaults
>  			* conditions when it occurs..*/
>  			BCM_DEBUG_PRINT(Adapter, DBG_TYPE_TX, NEXT_SEND,

Checkpatch is a tool that finds ugly code.  You've silenced the
warning.  The code still looks like dog vommit, but now checkpatch
doesn't find it.  Don't do that.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/