linux-kernel - Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120925110519.GA28902@infradead.org>
Date:	Tue, 25 Sep 2012 08:05:19 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Feng Tang <feng.tang@...el.com>, mingo@...e.hu,
	a.p.zijlstra@...llo.nl, andi@...stfloor.org, dsahern@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c
 to util/hist.c

Em Tue, Sep 25, 2012 at 10:25:13AM +0900, Namhyung Kim escreveu:
> On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu:
> >> Which looks more natural
> >
> > It is there to avoid dragging the hist code into the python binding :-\
> 
> Hmm... it's so hairy.  Can't we do better?

We always can do better :-)

I just stated why it was at that place.

When doing refactorings we're all the time trying to make it better in
many senses, one of them is trying to isolate code that is useful in a
general way and thus should be made available via a library/scripting
binding.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/