linux-kernel - Re: [PATCHv3 0/6] media: convert to c99 format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Sep 2012 08:09:26 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	Ezequiel Garcia <elezegarcia@...il.com>
Cc:	Shubhrajyoti D <shubhrajyoti@...com>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, julia.lawall@...6.fr
Subject: Re: [PATCHv3 0/6] media: convert to c99 format

Em Ter, 2012-09-25 às 08:03 -0300, Ezequiel Garcia escreveu:
> Shubhrajyoti,
> 
> Thanks for your patches.
> 
> I'm adding media maintainer (Mauro) in Cc. When you send
> patches for a file you should check who maintains them
> and put those people in Cc.

I actually prefer to not be c/c on the patches ;) Copying the
linux-media mailing list and checking if the patch was caught by
patchwork.linuxtv.kernel.org is enough, as I rely on patchwork to
queue patches for me. So, I just discard any media patch sent to me
directly.

> 
> This is really easy with get_maintainer.pl. You can also
> check with git log / git blame to see who has been working
> on that file.
> 
> You should read Documentation/SubmittingPatches
> if you haven't already (and read it again if you already have ;-)
> 
> On Tue, Sep 18, 2012 at 8:44 AM, Shubhrajyoti D <shubhrajyoti@...com> wrote:
> > The series tries to convert the i2c_msg to c99 struct.
> > This may avoid issues like below if someone tries to add an
> > element to the structure.
> > http://www.mail-archive.com/linux-i2c@vger.kernel.org/msg08972.html
> >
> > Special thanks to Julia Lawall for helping it automate.
> > By the below script.
> > http://www.mail-archive.com/cocci@diku.dk/msg02753.html
> >
> > Changelogs
> > - Remove the zero inititialisation of the flags.
> >
> > Shubhrajyoti D (6):
> >   media: Convert struct i2c_msg initialization to C99 format
> >   media: Convert struct i2c_msg initialization to C99 format
> >   media: Convert struct i2c_msg initialization to C99 format
> >   media: Convert struct i2c_msg initialization to C99 format
> >   media: Convert struct i2c_msg initialization to C99 format
> >   media: Convert struct i2c_msg initialization to C99 format
> >
> 
> IMO, sending several different patches with the same commit
> subject is not the best thing to do.
> 
> Perhaps this is too much to ask, but I'd prefer something
> like:
> 
> media: saa7706h: Convert struct i2c_msg initialization to C99 format
> 
> >  drivers/media/i2c/ks0127.c                    |   13 +++++++-
> >  drivers/media/i2c/msp3400-driver.c            |   40 +++++++++++++++++++++----
> >  drivers/media/i2c/tvaudio.c                   |   13 +++++++-
> >  drivers/media/radio/radio-tea5764.c           |   13 ++++++--
> >  drivers/media/radio/saa7706h.c                |   15 ++++++++-
> >  drivers/media/radio/si470x/radio-si470x-i2c.c |   23 ++++++++++----
> >  6 files changed, 96 insertions(+), 21 deletions(-)
> >
> 
> Thanks!
> Ezequiel.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/