linux-kernel - Re: [BUG] perf/x86: Intel uncore_pmu_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1348572025.3881.17.camel@twins>
Date:	Tue, 25 Sep 2012 13:20:25 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"Yan, Zheng" <zheng.z.yan@...el.com>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"mingo@...e.hu" <mingo@...e.hu>
Subject: Re: [BUG] perf/x86: Intel uncore_pmu_to_box() local variable typo

On Tue, 2012-09-25 at 12:44 +0200, Stephane Eranian wrote:
> Hi,
> 
> I don't understand why the local variable box needs to
> be declared static here:
> 
> static struct intel_uncore_box *
> uncore_pmu_to_box(struct intel_uncore_pmu *pmu, int cpu)
> {
>         static struct intel_uncore_box *box;
> 
>         box = *per_cpu_ptr(pmu->box, cpu);
>         if (box)
>                 return box;
>         ....
> }

Uhmm.. me neither.. that looks like a bug indeed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/