linux-kernel - Re: [PATCH] staging/gdm72xx: coding style fixes gdm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120925133033.GT4587@mwanda>
Date:	Tue, 25 Sep 2012 16:30:33 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	ldv-project@...uxtesting.org,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging/gdm72xx: coding style fixes gdm_qos.c

On Tue, Sep 25, 2012 at 04:53:52PM +0400, Alexey Khoroshilov wrote:
> Fix checkpatch.pl warnings:
> WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
> WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
> WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
> 

Better to just replace the dprintk macros instead of prettifying
them.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/