linux-kernel - Re: [PATCH] staging: sbe-2t3e3: fix error handling in t3e3_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120925133745.GU4587@mwanda>
Date:	Tue, 25 Sep 2012 16:37:45 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:	Krzysztof Halasa <khc@...waw.pl>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, ldv-project@...uxtesting.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sbe-2t3e3: fix error handling in
 t3e3_init_channel()

On Tue, Sep 25, 2012 at 04:56:02PM +0400, Alexey Khoroshilov wrote:
> t3e3_init_channel() incorrectly handles errors in several places:
> it returns zero and does not deallocate all required resources.
> The patch fixes that places.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>

Looks good.

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/