linux-kernel - Re: [PATCH] matroxfb: Convert struct i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM=Q2cv8ewLvKafU_iaxM4cq+G54K2rDu4Hd6Cj5cEtpZVf1qw@mail.gmail.com>
Date:	Tue, 25 Sep 2012 09:24:46 +0530
From:	Shubhrajyoti Datta <omaplinuxkernel@...il.com>
To:	Shubhrajyoti D <shubhrajyoti@...com>
Cc:	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	julia.lawall@...6.fr
Subject: Re: [PATCH] matroxfb: Convert struct i2c_msg initialization to C99 format

On Mon, Sep 17, 2012 at 9:25 PM, Shubhrajyoti D <shubhrajyoti@...com> wrote:
> Convert the struct i2c_msg initialization to C99 format. This makes
> maintaining and editing the code simpler. Also helps once other fields
> like transferred are added in future.
>
> Thanks to Julia Lawall <julia.lawall@...6.fr>  for automating the conversion

ping.

>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@...com>
> ---
> the cocci file was posted
> http://www.mail-archive.com/cocci@diku.dk/msg02753.html
>
>  drivers/video/matrox/matroxfb_maven.c |   15 +++++++++++++--
>  1 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c
> index 217678e..fb5c123 100644
> --- a/drivers/video/matrox/matroxfb_maven.c
> +++ b/drivers/video/matrox/matroxfb_maven.c
> @@ -137,8 +137,19 @@ static int* get_ctrl_ptr(struct maven_data* md, int idx) {
>
>  static int maven_get_reg(struct i2c_client* c, char reg) {
>         char dst;
> -       struct i2c_msg msgs[] = {{ c->addr, I2C_M_REV_DIR_ADDR, sizeof(reg), &reg },
> -                                { c->addr, I2C_M_RD | I2C_M_NOSTART, sizeof(dst), &dst }};
> +       struct i2c_msg msgs[] = {{
> +                                       .addr = c->addr,
> +                                       .flags = I2C_M_REV_DIR_ADDR,
> +                                       .len = sizeof(reg),
> +                                       .buf = &reg
> +                               },
> +                               {
> +                                       .addr = c->addr,
> +                                       .flags = I2C_M_RD | I2C_M_NOSTART,
> +                                       .len = sizeof(dst),
> +                                       .buf = &dst
> +                               }
> +       };
>         s32 err;
>
>         err = i2c_transfer(c->adapter, msgs, 2);
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/